-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s dependencies to 1.12.3 #807
Conversation
/cc @joelanford |
c30fb09
to
bc0502e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than a couple of nits.
4829efb
to
6360905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on green 🎉 🍏
/hold until the controller-runtime cuts the tag for v0.1.8 |
ab16ee6
to
71cfb24
Compare
We can update to controller-runtime v0.1.8 in this PR. |
1725683
to
ac70ec8
Compare
pkg/helm/release/manager*.go: fix broken API's from k8s upgrade
ac70ec8
to
ef49d21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@estroz Can you please submit a PR to update the CHANGELOG. We just need to point out the changes for updating to k8s 1.12.3 and controller-runtime v0.1.8. |
* Gopkg.toml: kubernetes 1.12.3 * pkg/helm/release/manager*.go: fix broken API's from k8s upgrade * bump scaffolded k8s dependencies to v1.12.3 * fix controller-runtime to v0.1.8 * bump helm to v2.12.0 * revendor
* Gopkg.toml: kubernetes 1.12.3 * pkg/helm/release/manager*.go: fix broken API's from k8s upgrade * bump scaffolded k8s dependencies to v1.12.3 * fix controller-runtime to v0.1.8 * bump helm to v2.12.0 * revendor
Description of the change: bump all kubernetes version to v1.12.2. Some
pkg/helm
API calls broke, which are now fixed.Motivation for the change: new version == happy users (most of the time).
Closes #808