commands/.../test/local,pkg/test: add image flag to test local #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
AlexNPavel
force-pushed
the
test-spec-image
branch
2 times, most recently
from
4bbdfe6 to
99a96b2
Compare
openshift-ci-robot
added
size/L
AlexNPavel
force-pushed
the
test-spec-image
branch
from
99a96b2 to
1241f4e
Compare
openshift-ci-robot
added
size/M
estroz
reviewed
Nov 21, 2018
hasbro17
reviewed
Nov 21, 2018
estroz
approved these changes
Nov 22, 2018
AlexNPavel
force-pushed
the
test-spec-image
branch
from
acb15d8 to
d1bc3a4
Compare
hasbro17
reviewed
Nov 26, 2018
|
@AlexNPavel Can we add a one line explanation and example usage of this flag in the writing-e2e-tests doc? |
AlexNPavel
force-pushed
the
test-spec-image
branch
2 times, most recently
from
504e3ff to
23928a2
Compare
|
@hasbro17 Added documentation |
AlexNPavel
force-pushed
the
test-spec-image
branch
from
23928a2 to
d57cad2
Compare
hasbro17
reviewed
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: Adds a
--imageflag to thetest localsubcommand. Currently only supports 1 deployment with 1 container (we may add support for multi-deployment, multi-container manifests in the future, but it would also require more flags from the user to identify which image needs to be replaced).Motivation for the change: See #746
Resolves #746
cc @awgreene