Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of CSV scaffold and update process #673

Merged
merged 69 commits into from
Jan 24, 2019
Merged

Implementation of CSV scaffold and update process #673

merged 69 commits into from
Jan 24, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Oct 31, 2018

Description of the change: implementation of #516

Motivation for the change: see #516

@estroz estroz added kind/feature Categorizes issue or PR as related to a new feature. design needs discussion labels Oct 31, 2018
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2018
@estroz estroz mentioned this pull request Oct 31, 2018
Merged
@estroz estroz force-pushed the csv-gen-prototype branch 2 times, most recently from 571d0d8 to 5933293 Compare October 31, 2018 22:28
@estroz estroz force-pushed the csv-gen-prototype branch 4 times, most recently from 0a0b2d5 to 1fa3d8e Compare November 12, 2018 23:42
@estroz estroz force-pushed the csv-gen-prototype branch 7 times, most recently from bc53be0 to 400176e Compare November 26, 2018 20:40
@estroz estroz changed the title [WIP] Implementation of CSV scaffold and update process Implementation of CSV scaffold and update process Nov 26, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2018
@estroz
Copy link
Member Author

estroz commented Nov 26, 2018

I'll be removing log.Info statements before merging.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2018
@dmesser
Copy link
Contributor

dmesser commented Jan 23, 2019

To allow easy handover to OLM and/or contribution to the community operators repo it would be great if we could scaffold the rest of the package structure according to:

@estroz
Copy link
Member Author

estroz commented Jan 23, 2019 •
edited
Loading

@dmesser check out #900 for prior discussion on how we plan to organize Catalog dir structure. I plan on implementing something similar to what you've suggested. Feel free to contribute to that discussion as well. I'll be submitting a followup PR to restructure dirs.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2019
@hasbro17
Copy link
Contributor

@estroz Overall this seems pretty good.
Just want to resolve the issue of how to populate the CRD displayName and description fields and this should be good to merge.

hasbro17
hasbro17 approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit d39ab6c into operator-framework:master Jan 24, 2019
@estroz estroz deleted the csv-gen-prototype branch January 24, 2019 22:06
@awgreene awgreene mentioned this pull request Jan 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@lilic lilic lilic left review comments

@AlexNPavel AlexNPavel AlexNPavel approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@ecordell ecordell Awaiting requested review from ecordell

Assignees
No one assigned
Labels
design kind/feature Categorizes issue or PR as related to a new feature. needs discussion size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.