-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix java bump changelog in v1.18.0 docs #5614
Conversation
modified the Quarkus operator SDK version and tutorial too | ||
chore: bump fabric8 5.8.0 & quarkus 2.4.0 | ||
modified the doc file and removed file after generation | ||
release: fix release script to understand release branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not use here - as a prefix of all lines?
Signed-off-by: Jonathan Berkhahn <[email protected]>
So what is this trying to fix? I had a changelog for my v0.2.0 and my v0.3.0 bumps.
So what's working? |
@jmrodri This PR is to fix the page in the upgrading-sdk docs, which is supposed to get populated from the changelog fragments, right? But currently there's a section that looks like changelog boilerplate where the bit from your PR is supposed to be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Jonathan Berkhahn <[email protected]> Signed-off-by: Prashant Arya <[email protected]>
Signed-off-by: Jonathan Berkhahn <[email protected]>
This wasn't actually a typo, seems @jmrodri forgot to fill in his changelog fragment?
fixes #5576