log error for url verification failure #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@germondc Thanks for the PR! Could you please sign the commit with |
Signed-off-by: Clyde Germond <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Sure thing. I have done so and pushed. |
|
Is not it missing the changelog with the fix? WDYT about adding this one for we have this fix in the release notes? |
Signed-off-by: Clyde Germond <[email protected]>
Such a small change, hardly seemed worth a changelog :) I have added one. |
prary
pushed a commit
to prary/operator-sdk
that referenced
this pull request
Apr 2, 2022
* log error for url verification failure Signed-off-by: Clyde Germond <[email protected]> Signed-off-by: Prashant Arya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Simply logs the already generated error prior to exiting
Motivation for the change:
Prevent silent exit of ansible-operator when URL fails verification.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docsApologies if I haven't followed the process correctly.