Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup syntax for deploy-manual. #5345

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Nov 8, 2021

This action (AFAICT) can't be tested locally or with PRs. A previous
commit mixed up 2 variable scopes.

Signed-off-by: austin [email protected]

This action (AFAICT) can't be tested locally or with PRs. A previous
commit mixed up 2 variable scopes.

Signed-off-by: austin <[email protected]>
@openshift-ci openshift-ci bot requested review from jmrodri and joelanford November 8, 2021 15:24
@asmacdo
Copy link
Member Author

asmacdo commented Nov 8, 2021

Here's the output I got from running deploy manual:
Screenshot from 2021-11-08 10-15-00

Looks like I changed the wrong tag variable previously.
Screenshot from 2021-11-08 10-14-36

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@asmacdo asmacdo merged commit 3612ce3 into operator-framework:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants