Remove Helm diffs output for "info" zap log level #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenkatRamaraju
changed the title
asmacdo
reviewed
Oct 12, 2021
| # release notes and/or the migration guide | ||
| entries: | ||
| - description: > | ||
| Helm operators will now not display the reconciliaton |
There was a problem hiding this comment.
This is fine as-is, but in the interest of being as concise and clear as possible, IMO it is best to say what the behavior is, rather than what it is not.
"Helm operator reconciliation diffs are now logged only at the debug level."
There was a problem hiding this comment.
@asmacdo Cool, just did all the above.
…r release diffs Signed-off-by: Venkat Ramaraju <[email protected]>
VenkatRamaraju
force-pushed
the
helm-logging
branch
from
0f3ddf2 to
a14a3e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Increased the verbosity threshold so that reconciliation diffs for Helm is not displayed when zap log level is set to "info."
Motivation for the change:
Close #5278
Notes