Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ansible-operator-base image update #5261

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Sep 29, 2021

Signed-off-by: austin [email protected]

Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
Comment on lines +58 to +63
1. Kick off a new build of the [ansible-operator-base
image](https://quay.io/repository/operator-framework/ansible-operator-base)
by running the
[deploy-manual](https://github.com/operator-framework/operator-sdk/actions/workflows/deploy-manual.yml)
GitHub action. After the image is built, check the security scan
results under `Child Manifests`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'd make this a requirement for doing a release. These can be done at any point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be done at any time, but it seems like it should always be done right before a release. Can we make it a requirement until we come up with some other process that will guarantee it is done when it needs to be done?

Copy link
Member Author

@asmacdo asmacdo Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshaprasad96 I'd like to get this into 1.13.0, do you think we are good to merge as is? @jmrodri I'll revert if I'm wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind having this as a pre-req for release for now. Its better to have it verified that we are on latest before a release though we can do it anytime too. Similar to how we update olm biodata (we have it as pre-req before a release, though we can have a PR to do to anytime a new OLM version is out).

@asmacdo asmacdo modified the milestones: v1.13.0, v1.14.0 Sep 29, 2021
@asmacdo asmacdo merged commit 096ea83 into operator-framework:master Sep 29, 2021
@asmacdo asmacdo modified the milestones: v1.14.0, v1.13.0 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants