Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.10.x] fix(generate): exclude ServiceAccounts in the CSV from generated bundle #5124

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[v1.10.x] fix(generate): exclude ServiceAccounts in the CSV from generated bundle #5124

merged 1 commit into from
Aug 5, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5120

/assign estroz

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 5, 2021
Merged
2 tasks
@openshift-ci openshift-ci bot requested review from jberkhahn and joelanford August 5, 2021 17:07
estroz
estroz approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
asmacdo
asmacdo approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rashmigottipati
rashmigottipati approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz merged commit ca54e14 into operator-framework:v1.10.x Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmacdo asmacdo asmacdo approved these changes

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@estroz estroz estroz approved these changes

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@asmacdo asmacdo

@rashmigottipati rashmigottipati

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @asmacdo @rashmigottipati @estroz