Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend local roles path to ANSIBLE_ROLES_PATH #5118

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Aug 4, 2021

closes: #4071

When running locally, we set the ANSIBLE_ROLES_PATH to include the local
roles path, preventing users from needing to manually setting this
environment variable for normal development.

Signed-off-by: austin [email protected]

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from jmrodri and theishshah August 4, 2021 17:43
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@asmacdo asmacdo force-pushed the add-local-roles-path branch from e46cf56 to 0adaa1a Compare August 4, 2021 17:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
closes: operator-framework#4071

When running locally, we set the ANSIBLE_ROLES_PATH to include the local
roles path, preventing users from needing to manually setting this
environment variable for normal development.

Signed-off-by: austin <[email protected]>
@asmacdo asmacdo force-pushed the add-local-roles-path branch from 0adaa1a to aaec357 Compare August 4, 2021 18:09
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@asmacdo asmacdo merged commit a4b99a8 into operator-framework:master Aug 4, 2021
bentito pushed a commit to bentito/operator-sdk that referenced this pull request Aug 24, 2021
closes: operator-framework#4071

When running locally, we set the ANSIBLE_ROLES_PATH to include the local
roles path, preventing users from needing to manually setting this
environment variable for normal development.

Signed-off-by: austin <[email protected]>
twasyl pushed a commit to twasyl/operator-sdk that referenced this pull request Sep 3, 2021
closes: operator-framework#4071

When running locally, we set the ANSIBLE_ROLES_PATH to include the local
roles path, preventing users from needing to manually setting this
environment variable for normal development.

Signed-off-by: austin <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"make run" fails for scaffolded Ansible operator with roles
3 participants