Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SA for the operator #454

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Create SA for the operator #454

merged 1 commit into from
Sep 21, 2018

Conversation

ccronca
Copy link
Contributor

@ccronca ccronca commented Sep 2, 2018

ref: #189

@CSdread
Copy link
Contributor

CSdread commented Sep 14, 2018

@camilocot can you get the conflict fixed up? @spahl @hasbro17 any chance we can push this one up, we have code that does this but could be removed if we pull this in ;)

@ccronca
Copy link
Contributor Author

ccronca commented Sep 16, 2018

@CSdread conflicts fixed.

@CSdread
Copy link
Contributor

CSdread commented Sep 17, 2018

do we know what the side effects are for folks not yet using SA and RBAC would the functionality be the same?

@CSdread
Copy link
Contributor

CSdread commented Sep 17, 2018

@camilocot so a few things, first if you would read the contributor document in the repo root, the format for naming commits and PRs, can we get you to fix that part?

@hasbro17
Copy link
Contributor

@CSdread Sorry I've been busy with other reviews and the controller-runtime refactoring work. Will try to prioritize this in this week.
/cc @AlexNPavel we need to consider how this affects the test-framework.

@AlexNPavel
Copy link
Contributor

The comment on line 58 of commands/operator-sdk/cmd/test.go should be updated:

operator-sdk/commands/operator-sdk/cmd/test.go

Line 58 in c84b1a9

// if no namespaced manifest path is given, combine deploy/rbac.yaml and deploy/operator.yaml

@AlexNPavel
Copy link
Contributor

The user guide (doc/user-guide.md) needs to be updated as well

@ccronca
test/*,pkg/generator,commands,user-guide: Add SA for the operator
5c74521 
This avoids running the operator using the 'default' service account.

Fixes #189
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2018
@AlexNPavel
Copy link
Contributor

lgtm

@CSdread
Copy link
Contributor

CSdread commented Sep 21, 2018

lgtm as well

@CSdread
Copy link
Contributor

CSdread commented Sep 21, 2018

@hasbro17 this is ready for merge we believe

@hasbro17
Copy link
Contributor

LGTM

@hasbro17 hasbro17 merged commit 72431e2 into operator-framework:master Sep 21, 2018
dymurray pushed a commit to dymurray/operator-sdk that referenced this pull request Sep 26, 2018
@dymurray
test/*,pkg/generator,commands,user-guide: Add SA for the operator (op…
ef00bed 
…erator-framework#454)

This avoids running the operator using the 'default' service account.

Fixes operator-framework#189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccronca @CSdread @hasbro17 @AlexNPavel @openshift-ci-robot