Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-operator|helm-operator: add the kubernetes auth clients #3974

Conversation

cts-zeero
Copy link
Contributor

@cts-zeero cts-zeero commented Oct 5, 2020

This PR adds the kubernetes auth clients to the ansible-operator and
helm-operator binaries.

Closes #3973

Description of the change:

This PR adds the kubernetes auth clients to the ansible and helm operator binaries.

Motivation for the change:

The change enables the ansible and helm operator binaries to run in local mode using gcp, azure, etc auth providers.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing the fragment which is used to create the CHANGELOG.
Could you please add it?

Otherwise, it shows fine for me. 👍

This PR adds the kubernetes auth clients to the ansible-operator and
helm-operator binaries.

Closes operator-framework#3973
@cts-zeero cts-zeero force-pushed the fix-auth-provider-imports branch from 600ca11 to fd771d7 Compare October 5, 2020 17:54
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@camilamacedo86 camilamacedo86 merged commit 9cebb81 into operator-framework:master Oct 5, 2020
@joelanford
Copy link
Member

/cherry-pick v0.19.x

@openshift-cherrypick-robot

@joelanford: #3974 failed to apply on top of branch "v0.19.x":

Applying: ansible-operator|helm-operator: add the kubernetes auth clients
.git/rebase-apply/patch:16: trailing whitespace.
      Added kubernetes authentication clients to `ansible-operator` and 
.git/rebase-apply/patch:17: trailing whitespace.
      `helm-operator` to enable authentication to gcp, azure, etc. kubernetes 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	cmd/ansible-operator/main.go
M	cmd/helm-operator/main.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/helm-operator/main.go
CONFLICT (content): Merge conflict in cmd/helm-operator/main.go
Auto-merging cmd/ansible-operator/main.go
CONFLICT (content): Merge conflict in cmd/ansible-operator/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ansible-operator|helm-operator: add the kubernetes auth clients
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick v0.19.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford
Copy link
Member

/cherry-pick v1.0.x

@openshift-cherrypick-robot

@joelanford: new pull request created: #3976

In response to this:

/cherry-pick v1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelanford pushed a commit to joelanford/operator-sdk that referenced this pull request Oct 5, 2020
…ator-framework#3974)

This PR adds the kubernetes auth clients to the ansible-operator and
helm-operator binaries.

Closes operator-framework#3973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible-operator gcp auth provider not found
6 participants