Removing stale sockets while running Ansible operators #3721
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "io" | ||
| "io/ioutil" | ||
| "net" | ||
| "net/http" | ||
| "os" | ||
| logf "sigs.k8s.io/controller-runtime/pkg/log" |
There was a problem hiding this comment.
Missing fragment and fix the order of the imports.
Comment on lines
+3
to
+5
| Removed stale unix sockets. This allows for smoother | ||
| initialization during the start-up of an Ansible operator, | ||
| as each operator will clean up its sockets during termination. |
There was a problem hiding this comment.
Suggested change
| Removed stale unix sockets. This allows for smoother | |
| initialization during the start-up of an Ansible operator, | |
| as each operator will clean up its sockets during termination. | |
| Remove stale Unix sockets when the events are closed in order to optimize the initialization process of Ansible-based Operators. |
There was a problem hiding this comment.
Just a nit ^ Otherwise /lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Removed stale sockets during the closing of Ansible operators.
Motivation for the change:
Removing of unused/stale sockets allows for smoother initialization of the operator during start-up.