Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/plugins/helm/v1/scaffolds/templates/role.go: simplify updates #3482

Merged
merged 1 commit into from
Jul 21, 2020
Merged

internal/plugins/helm/v1/scaffolds/templates/role.go: simplify updates #3482

merged 1 commit into from
Jul 21, 2020

Conversation

joelanford
Copy link
Member

Description of the change:
No longer use complex logic to merge roles from multiple APIs together. Instead use a marker in role.yaml to always just append new rules when APIs are added

Motivation for the change:

  1. Comments never survived roundtrips through the rule merge process. Now they do
  2. With multiple APIs it was impossible to tell which rules we're for which API. Now, when each API is created, a new comment will be prepended in the added rule list that clearly delineates each section of rules. This will make it much easier for operator developers to maintain.

camilamacedo86
camilamacedo86 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 21, 2020
@camilamacedo86 camilamacedo86 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@joelanford joelanford merged commit 5fbd651 into operator-framework:master Jul 21, 2020
@joelanford joelanford deleted the helm-role-gen branch July 21, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelanford @camilamacedo86 @openshift-ci-robot