Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for alpha scorecard cmd #3318

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add unit tests for alpha scorecard cmd #3318

merged 1 commit into from
Jul 1, 2020

Conversation

jberkhahn
Copy link
Contributor

Description of the change:
Add unit tests for cmd/alpha/scorecard

Motivation for the change:
Unit tests are cool. See #3246

@jberkhahn jberkhahn mentioned this pull request Jul 1, 2020
Closed
@jberkhahn
Copy link
Contributor Author

The travis tests are actually passing, seems github is out of sync.

@camilamacedo86 camilamacedo86 merged commit b1c31f7 into operator-framework:master Jul 1, 2020
camilamacedo86
camilamacedo86 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jberkhahn jberkhahn mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmccormick2001 jmccormick2001 jmccormick2001 approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@estroz estroz Awaiting requested review from estroz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberkhahn @jmccormick2001 @camilamacedo86