-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scorecard new API #3125
Merged
bharathi-tenneti
merged 11 commits into
operator-framework:master
from
bharathi-tenneti:scorecardapi
Jun 4, 2020
Merged
scorecard new API #3125
bharathi-tenneti
merged 11 commits into
operator-framework:master
from
bharathi-tenneti:scorecardapi
Jun 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmccormick2001
approved these changes
May 28, 2020
estroz
suggested changes
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
estroz
reviewed
May 29, 2020
joelanford
reviewed
Jun 1, 2020
estroz
reviewed
Jun 1, 2020
jmccormick2001
approved these changes
Jun 4, 2020
estroz
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: To support additional scorecard2 features, we need the scorecard APi to be updated, for this, we need a new set of API structs that serve 2 key purposes:
--create a structure around the information presented by the List function (labels, image)
--create an ability for a test entrypoint to produce n-number of test results (e.g. suite of tests)
for this, the groupname/version will need to be updated and new golang structs will need to be generated/added