Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle create: set default channel if only one channel is set #3124

Merged

Conversation

estroz
Copy link
Member

@estroz estroz commented May 27, 2020

Description of the change: set default channel if only one channel is set

Motivation for the change: a default channel should always be set, and we can infer which one it is if there is only one channel.

See #3106 (comment)

/cc @hasbro17 @camilamacedo86

Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinhxuanvu
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@estroz estroz merged commit 12679ce into operator-framework:master May 27, 2020
@estroz estroz deleted the feature/set-bundle-default-channel branch May 27, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants