bundle validate: include both warnings and errors #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
estroz
force-pushed
the
refactor/validate-bundle-with-warnings
branch
7 times, most recently
from
dd448c1 to
0b4b9be
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
force-pushed
the
refactor/validate-bundle-with-warnings
branch
from
0b4b9be to
4377bb2
Compare
hasbro17
reviewed
May 23, 2020
estroz
force-pushed
the
refactor/validate-bundle-with-warnings
branch
from
4377bb2 to
e80b2ec
Compare
| // also validated to confirm if they are "kubectl-able" to a cluster meaning | ||
| // if they can be applied to a cluster using `kubectl` provided users have all | ||
| // necessary permissions and configurations. | ||
| func ValidateBundleContent(logger *log.Entry, bundle *apimanifests.Bundle, |
There was a problem hiding this comment.
Would not make more sense we centralize all bundle validations in the Operator Registry? Also, should responsibility of the lib return WARNs, ERROR's and INFO's instead we do it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
validatewill print errors and warnings from validation.ValidateBundleContentvalidates a bundle with a given mediaType, returning the results of validation to be analysed/printed.Motivation for the change: operator-sdk users should be aware of both required and optional aspects of a bundle when running
bundle validate./kind feature
Depends on #3081