run: deprecate '--local' flag in favor of 'local' subcommand #3067
Conversation
openshift-ci-robot
added
the
kind/feature
| helmOperatorFlags *hoflags.HelmOperatorFlags | ||
| type RunLocalCmd struct { | ||
| Kubeconfig string | ||
| WatchNamespace string |
There was a problem hiding this comment.
| WatchNamespace string | |
| // Valid just for the legacy layout | |
| // todo: remove when the legacy layout is no longer supported | |
| WatchNamespace string |
There was a problem hiding this comment.
Seeing as projects created with init can be namespaced (with extra work), I don't see a reason to ever remove this.
There was a problem hiding this comment.
Furthermore do we want to disable setting --watch-namespaces, as we currently do, for new project layouts, considering that they can be namespaced @joelanford @hasbro17? Out of scope for this PR, still worth discussing.
There was a problem hiding this comment.
Hi @estroz, It is disabled for kb layout already. I understand that so far we do not think in port this for kb layouts. Let me know if I misunderstand something here @joelanford and @hasbro17
However, may can be good we track (create a task) to check if has any reason that would justify we push this for the new layout as well.
There was a problem hiding this comment.
It is currently disabled, and I'm wondering if we want to continue to do that. If a new project layout is made to be namespaced (manager consumes --namespaces or WATCH_NAMESPACE), shouldn't they be able to use --watch-namespaces?
There was a problem hiding this comment.
The WATCH_NAMESPACE feature requires changes in the scaffold which are not made in the kb layout. So, was decided that until we have sure that we would like to migrate this feature and it can bring value for the new layout the flag should be hidden and not "officially" deprecated. See the comments in the code; https://github.com/operator-framework/operator-sdk/pull/3067/files#diff-3b91b8e7a6ffd108dcc88e06b3c11a01R41-R43
PS: Since it is related to the operator scope setup options as well. I added in the operator scope doc the steps which would be required to have the code changes that also could allow the flags work. See: https://github.com/operator-framework/operator-sdk/pull/2982/files#diff-f0fb41913d0dbfca6bcc82359ab92aacR113-R185
There was a problem hiding this comment.
We can address this in a follow-up.
estroz
force-pushed
the
refactor/run-local-cmd
branch
2 times, most recently
from
a818905 to
d7aa7ff
Compare
There was a problem hiding this comment.
It is /LGTM for me after address the comment: https://github.com/operator-framework/operator-sdk/pull/3067/files#r427810597
'run --local' should be removed 2 versions after this commit is released cmd/operator-sdk/run: move 'local' and 'packagemanifests' subcommand code into their own packages *: s/--local/local/g in docs
estroz
force-pushed
the
refactor/run-local-cmd
branch
from
446e228 to
2d5be98
Compare
Description of the change:
Motivation for the change: follows the pattern of
run packagemanifestsand `run bundle./kind feature