bundle validate: new alpha flag `--output=<text|json-alpha1>` to format results #3011

camilamacedo86 · 2020-05-12T16:44:48Z

Description of the change:
Alpha hidden flag. See:

With success:

With Error:

cmd/operator-sdk/bundle/validate.go

cmd/operator-sdk/bundle/output.go

cmd/operator-sdk/bundle/validate.go

cmd/operator-sdk/bundle/cmd.go

camilamacedo86 · 2020-05-14T13:08:52Z

HI @estroz,

Thank your for your review and great suggestions. All are addressed with 1 exception only as described above.

cmd/operator-sdk/bundle/validate.go

joelanford

To me this seems like a large code change for effectively just calling json.Marshal on the result of the validation.

cmd/operator-sdk/bundle/validate.go

cmd/operator-sdk/bundle/output.go

cmd/operator-sdk/bundle/validate.go

cmd/operator-sdk/bundle/output.go

cmd/operator-sdk/bundle/validate.go

camilamacedo86

@joelanford @estroz,

I changed the impl to use the dep instead of we impl the output structure which makes the thing easier and cleaner. See:

Let me know what do you think and if we can move forward with now.

camilamacedo86 · 2020-05-22T18:49:05Z

Hi @estroz,

After all possibilities and suggestions, it is now updated and done on with your ideal one. Please, feel free to check. :-) Relly tks for the help, I think that it is much better now following your approach. 🥇

estroz

Getting there, although the JSON spec should be internal to the SDK (for now).

cmd/operator-sdk/bundle/validate.go

pkg/output/logger.go

pkg/output/result.go

cmd/operator-sdk/bundle/validate.go

camilamacedo86 · 2020-05-25T08:29:48Z

Hi @estroz,

All is done here, could you please give a hand in its review?
Really tks.

estroz

Structure is getting there.

cmd/operator-sdk/bundle/validate.go

go.mod

go.sum

internal/output/logger.go

cmd/operator-sdk/bundle/validate.go

camilamacedo86 · 2020-05-27T23:32:43Z

Hi @estroz,

All done as suggested

Just here: #3011 (comment) I do not move with your comment because I thought that would be better re-check first since it would mean shows all validation tests have completed successfully with errors and warnings. However, if you think that is fine because it would mean that the command finishes then, I am OK about doing this change. Just let me know.

cmd/operator-sdk/bundle/validate.go

cmd/operator-sdk/scorecard/cmd.go

changelog/fragments/json-hidden-flag.yaml

estroz

A few nits then LGTM

estroz

/lgtm

openshift-ci-robot · 2020-05-28T09:35:49Z

New changes are detected. LGTM label has been removed.

…rator-sdk bundle validate` in JSON format.

… for others cmds

openshift-ci-robot requested review from jmrodri and varshaprasad96 May 12, 2020 16:44

camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. olm-integration Issue relates to the OLM integration labels May 12, 2020

estroz reviewed May 12, 2020

View reviewed changes

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

estroz reviewed May 12, 2020

View reviewed changes

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

estroz reviewed May 12, 2020

View reviewed changes

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

camilamacedo86 requested a review from estroz May 13, 2020 14:22

estroz suggested changes May 13, 2020

View reviewed changes

camilamacedo86 requested review from estroz, joelanford, fabianvf, hasbro17 and bharathi-tenneti May 14, 2020 13:08

estroz reviewed May 14, 2020

View reviewed changes

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

camilamacedo86 requested a review from estroz May 14, 2020 19:50

This comment has been minimized.

Sign in to view

joelanford reviewed May 14, 2020

View reviewed changes

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

camilamacedo86 changed the title ~~feat: Add new hidden alpha flag --json to output the result of operator-sdk bundle validate in JSON format.~~ feat: Add new hidden alpha flag --output to output the result of operator-sdk bundle validate in JSON format. May 14, 2020

This comment has been minimized.

Sign in to view

camilamacedo86 requested a review from joelanford May 14, 2020 23:24

estroz suggested changes May 15, 2020

View reviewed changes

camilamacedo86 requested a review from estroz May 15, 2020 19:06

tengqm reviewed May 17, 2020

View reviewed changes

cmd/operator-sdk/bundle/output.go Outdated Show resolved Hide resolved

tengqm reviewed May 17, 2020

View reviewed changes

cmd/operator-sdk/bundle/output.go Outdated Show resolved Hide resolved

tengqm reviewed May 17, 2020

View reviewed changes

camilamacedo86 commented May 17, 2020

View reviewed changes

camilamacedo86 closed this May 19, 2020

camilamacedo86 deleted the alpha-output-format branch May 19, 2020 09:52

camilamacedo86 restored the alpha-output-format branch May 19, 2020 15:01

camilamacedo86 reopened this May 19, 2020

estroz suggested changes May 22, 2020

View reviewed changes

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

pkg/output/logger.go Outdated Show resolved Hide resolved

pkg/output/result.go Outdated Show resolved Hide resolved

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 24, 2020

camilamacedo86 requested a review from estroz May 24, 2020 16:09

camilamacedo86 closed this May 25, 2020

camilamacedo86 reopened this May 25, 2020

estroz suggested changes May 27, 2020

View reviewed changes

estroz reviewed May 27, 2020

View reviewed changes

cmd/operator-sdk/bundle/validate.go Outdated Show resolved Hide resolved

estroz reviewed May 28, 2020

View reviewed changes

cmd/operator-sdk/scorecard/cmd.go Outdated Show resolved Hide resolved

estroz reviewed May 28, 2020

View reviewed changes

changelog/fragments/json-hidden-flag.yaml Outdated Show resolved Hide resolved

estroz suggested changes May 28, 2020

View reviewed changes

camilamacedo86 requested a review from estroz May 28, 2020 00:39

estroz approved these changes May 28, 2020

View reviewed changes

openshift-ci-robot assigned estroz May 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2020

camilamacedo86 added 4 commits May 28, 2020 18:45

feat: Add new hidden alpha flag --json to output the result of `ope…

18182a7

…rator-sdk bundle validate` in JSON format.

rebase + cleanup + add tests + address suggestionss

7007291

latest review - eric

1fc304e

cleanup since in the review was defined that the output cannot be use…

0b26b1d

… for others cmds

estroz changed the title ~~feat: Add new hidden alpha flag --output to output the result of operator-sdk bundle validate in JSON format.~~ bundle validate: new alpha flag --output=<text|json-alpha1> to format results May 28, 2020

estroz merged commit d1dbfc8 into operator-framework:master May 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bundle validate: new alpha flag `--output=<text|json-alpha1>` to format results #3011

bundle validate: new alpha flag `--output=<text|json-alpha1>` to format results #3011

camilamacedo86 commented May 12, 2020 •

edited

Loading

camilamacedo86 commented May 14, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joelanford left a comment

This comment has been minimized.

camilamacedo86 left a comment

camilamacedo86 commented May 22, 2020 •

edited

Loading

estroz left a comment

camilamacedo86 commented May 25, 2020

estroz left a comment

camilamacedo86 commented May 27, 2020 •

edited

Loading

estroz left a comment

estroz left a comment

openshift-ci-robot commented May 28, 2020

bundle validate: new alpha flag --output=<text|json-alpha1> to format results #3011

bundle validate: new alpha flag --output=<text|json-alpha1> to format results #3011

Conversation

camilamacedo86 commented May 12, 2020 • edited Loading

camilamacedo86 commented May 14, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joelanford left a comment

Choose a reason for hiding this comment

This comment has been minimized.

camilamacedo86 left a comment

Choose a reason for hiding this comment

camilamacedo86 commented May 22, 2020 • edited Loading

estroz left a comment

Choose a reason for hiding this comment

camilamacedo86 commented May 25, 2020

estroz left a comment

Choose a reason for hiding this comment

camilamacedo86 commented May 27, 2020 • edited Loading

estroz left a comment

Choose a reason for hiding this comment

estroz left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 28, 2020

bundle validate: new alpha flag `--output=<text|json-alpha1>` to format results #3011

bundle validate: new alpha flag `--output=<text|json-alpha1>` to format results #3011

camilamacedo86 commented May 12, 2020 •

edited

Loading

camilamacedo86 commented May 22, 2020 •

edited

Loading

camilamacedo86 commented May 27, 2020 •

edited

Loading