OLM client: correctly get packageserver version

[estroz]

Description of the change: use indexed CSV in list instead of an iterator value in internal/olm/client.Client.GetInstalledVersion.

Motivation for the change: if more than one CSV is installed in OLM's namespace, as is the case in some k8s distros, the list operation in GetInstalledVersion will return multiple CSV's. The bug resulted in the last CSV in the returned list, not necessarily the packageserver's, to be inspected for OLM's version.

/kind bug

/cc @raffaelespazzoli

[openshift-ci-robot]

@estroz: GitHub didn't allow me to request PR reviews from the following users: raffaelespazzoli.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of the change: use indexed CSV in list instead of an iterator value in internal/olm/client.Client.GetInstalledVersion.

Motivation for the change: if more than one CSV is installed in OLM's namespace, as is the case in some k8s distros, the list operation in GetInstalledVersion will return multiple CSV's. The bug resulted in the last CSV in the returned list, not necessarily the packageserver's, to be inspected for OLM's version.

/kind bug

/cc @raffaelespazzoli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[estroz]

/cherry-pick v0.17.x

[openshift-cherrypick-robot]

@estroz: new pull request created: #3029

In response to this:

/cherry-pick v0.17.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.