cmd/operator-sdk/internal: explicitly set GOROOT #2754
Conversation
If the user's GOROOT does not match the GOROOT used to build the binary, they would be required to explicitly set the GOROOT env variable to their go env GOROOT. To avoid this step for end-users we can explicitly pull the GOROOT from go env and explicitly set the GOROOT env variable. Fixes: operator-framework#2744
| @@ -34,6 +35,16 @@ import ( | |||
| func K8sCodegen() error { | |||
There was a problem hiding this comment.
Also, just one question, is the issue just faced with the operator-sdk generate k8s command?
There was a problem hiding this comment.
Good question. I tested in a failing environment (where I have release v0.16.0 and unset GOROOT), and both the crds and csv generate commands work without throwing any errors.
This seems to be isolated to the k8s generation.
|
Thanks for the quick turnaround on feedback on the PR! Pushed a patch commit, I was not sure if y'all prefer me to squash and update my branch, or if you handle the squash on the merge. Let me know if anything is out of place, and I'll keep note for future contributions. |
|
We squash on merge, so no worries. As soon as CI passes, I'll merge it in. Thanks again! |
Description of the change:
If the user's
GOROOTdoes not match theGOROOTused to build the binary, they would be required to explicitly set theGOROOTenv variable:To avoid this step for end-users we can explicitly pull the
GOROOTfromgo envand explicitly set theGOROOTenv variable prior to generation code executing.Motivation for the change:
Closes #2744