Properly handle resources with '-' in the group name #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources with '-' in the APIGroup now are properly formatted when passed to Ansible. For example ``` apiVersion: cert-manager.io/v1alpha2 kind: Certificate ``` will now result in a variabled called `_cert_manager_io_certificaterequest` instead of `_cert-manager_io_certificaterequest` Fixes operator-framework#2486
djzager
suggested changes
Mar 24, 2020
jmrodri
requested changes
Mar 24, 2020
There was a problem hiding this comment.
+1 for @jmrodri suggestion and add changelog :-)
Also, could we add any data mock test for this scenario easily?
Other
openshift-ci-robot
added
lgtm
fabianvf
force-pushed
the
ansible-escape-dash
branch
from
9edeeda to
704f941
Compare
djzager
approved these changes
Mar 25, 2020
|
New changes are detected. LGTM label has been removed. |
jmrodri
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources with '-' in the APIGroup now are properly formatted when
passed to Ansible. For example
will now result in a variabled called
_cert_manager_io_certificaterequestinstead of
_cert-manager_io_certificaterequestFixes #2486
Description of the change:
Motivation for the change: