add already exists check in object creation #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,7 +130,9 @@ func createFromYAMLFile(cfg BasicAndOLMPluginConfig, yamlPath string) error { | |||
| } | |||
| } | |||
| err = runtimeClient.Create(context.TODO(), obj) | |||
| if err != nil { | |||
| if errors.IsAlreadyExists(err) { | |||
There was a problem hiding this comment.
Great 👍
Missing just add changelog entry for the fix
There was a problem hiding this comment.
thanks, added the changelog entry.
| if err != nil { | ||
| if errors.IsAlreadyExists(err) { | ||
| fmt.Printf("already exists, %s, not creating.", yamlPath) | ||
| } else if err != nil { | ||
| _, restErr := restMapper.RESTMappings(obj.GetObjectKind().GroupVersionKind().GroupKind()) |
There was a problem hiding this comment.
Add a test for the scenario would be great as well. If it is not too much work
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
this PR fixes a situation where an operator being tested with scorecard, creates CRs in its implementation (seeded), this would cause scorecard to fail since it was trying to create the same CRs already seeded. With this change, if a CR is already created, the scorecard will just print a message to the user to let them know when a CR already exists.
Motivation for the change:
Closes #2677