Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs about needed cluster roles for e2e operator tests #2676

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Add docs about needed cluster roles for e2e operator tests #2676

merged 3 commits into from
Mar 23, 2020

Conversation

jberkhahn
Copy link
Contributor

Description of the change:
Add docs about the needed permissions for running e2e operator tests.

Motivation for the change:
As discussed in #1082 this is useful information for users in environments where they might not be running as cluster-admin by default.

Closes #1082

@jberkhahn jberkhahn force-pushed the test_roles branch 4 times, most recently from 209f532 to a5febe4 Compare March 19, 2020 00:00
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2020
@jberkhahn
Copy link
Contributor Author

are changes to /website supposed to be done manually? I submitted a previous docs PR that didn't fail the travis build.

camilamacedo86
camilamacedo86 reviewed Mar 19, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the content. Really thank you for your collab. 👍
Also, now we need to copy the same charges to .website/ dir. (it is temporary only, sorry for the inconvenience)
Could you please do that?

@camilamacedo86
Copy link
Contributor

Hi @jberkhahn,

The docs in a transition period. Temporary, we need to copy to keep both equals. So, yes. For we are able to move forward and it passes in the CI you need to perform the same changes in website/content/en/docs/test-framework/writing-e2e-tests.md. Could you please do that?

@jberkhahn
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@jberkhahn: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jberkhahn
Copy link
Contributor Author

this should be good to go?

estroz
estroz approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2020
@estroz estroz merged commit 536a83f into operator-framework:master Mar 23, 2020
@jberkhahn jberkhahn mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@estroz estroz estroz approved these changes

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document need for cluster-admin to run tests
4 participants
@jberkhahn @camilamacedo86 @openshift-ci-robot @estroz