Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CR has not error faced in the task #2661

Merged
merged 2 commits into from
Mar 16, 2020
Merged

fix: CR has not error faced in the task #2661

merged 2 commits into from
Mar 16, 2020

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Mar 16, 2020 •
edited
Loading

Description of the change:
The reconcile was not marking the CR status when no event status is returned.

Motivation for the change:

Closes #2565

Local Test
Screenshot 2020-03-16 at 16 46 02

@camilamacedo86 camilamacedo86 requested review from joelanford, bharathi-tenneti and varshaprasad96 and removed request for joelanford March 16, 2020 16:52
@camilamacedo86 camilamacedo86 added language/ansible Issue is related to an Ansible operator project kind/bug Categorizes issue or PR as related to a bug. labels Mar 16, 2020
fabianvf
fabianvf approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
djzager
djzager approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@camilamacedo86 camilamacedo86 merged commit 38e96f2 into operator-framework:master Mar 16, 2020
@camilamacedo86 camilamacedo86 deleted the fix-cr-status branch March 16, 2020 19:15
@camilamacedo86 camilamacedo86 mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@fabianvf fabianvf fabianvf approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@bharathi-tenneti bharathi-tenneti Awaiting requested review from bharathi-tenneti

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@fabianvf fabianvf

Labels
kind/bug Categorizes issue or PR as related to a bug. language/ansible Issue is related to an Ansible operator project lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CR has not error faced in the task
4 participants
@camilamacedo86 @djzager @fabianvf @openshift-ci-robot