Deprecated inotify-tools on Ansible based-operator images and remove Ansible sidecar container.
#2586
Conversation
openshift-ci-robot
added
the
size/L
camilamacedo86
changed the title
inotify-tools from Ansible based-operator images and the additional Ansible side-card container.
camilamacedo86
changed the title
inotify-tools from Ansible based-operator images and the additional Ansible side-card container.inotify-tools from Ansible based-operator images and the additional Ansible sidecar container.
There was a problem hiding this comment.
+1 to dropping the container from the scaffolding, but I think we should leave the script + script scaffolding in place for the time being (and maybe add in a deprecation warning or something). If we remove it right away it will break any operator deployment that uses the old scaffolding, but it's easy to keep it around for a few versions with a warning before dropping it completely. Even if we replaced the whole script with just an echoed This script is deprecated and will soon be removed it would at least stop deployments from failing completely. Thoughts?
internal/scaffold/ansible/ao_logs.go
Outdated
| @@ -1,52 +0,0 @@ | |||
| // Copyright 2019 The Operator-SDK Authors | |||
| ```yaml | ||
| - name: {{your operator name which is the value of metadata.name in this file}} | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@estroz I followed here your suggestion.
I will try to start to do that as well.
Let's see if it can build a good example/case in the order we start to do it for all.
| const aoLogsTmpl = `#!/bin/bash | ||
|
|
||
| echo "WARN: This script is deprecated and will soon be removed" | ||
|
|
||
| watch_dir=${1:-/tmp/ansible-operator/runner} |
There was a problem hiding this comment.
camilamacedo86
changed the title
inotify-tools from Ansible based-operator images and the additional Ansible sidecar container.inotify-tools on Ansible based-operator images and remove Ansible sidecar container.
…le logs on it (#2589) **Description of the change:** - Add full Ansible result output to the operator logs for Ansible based-operators configurable by EnvVar. **Motivation for the change:** Allow users to have the same full information that can be obtained until the version 0.15.x with the Ansible sidecar container in the operator logs. Note that we deprecated the inotify-tools and we will no longer scaffold the sidecar container. See #2586. Also, we have been improving the operator logs in order to attend all needs. See: #2580 and #2321.
Description of the change:
Motivation for the change:
Closes #2007