cmd/operator-sdk/run: use Windows binary suffix with '--local' #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, we need to add the .exe suffix to the executable that is generated by the operator-sdk run --local command, otherwise it will fail because the file doesn't have an executable extension. Fixes operator-framework#2480
openshift-ci-robot
added
the
size/XS
joelanford
previously requested changes
Jan 30, 2020
joelanford
reviewed
Feb 4, 2020
al45tair
force-pushed
the
windows-local-fix
branch
from
119b296 to
bf1f215
Compare
|
Hmmm. That test failure doesn't seem to be my doing. |
Co-Authored-By: Camila Macedo <[email protected]>
estroz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, we need to add the .exe suffix to the executable that is
generated by the operator-sdk run --local command, otherwise it will
fail because the file doesn't have an executable extension.
Closes #2480