Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/operator-sdk: 'olm-catalog gen-csv' -> 'generate csv' #2439

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jan 20, 2020

Description of the change:

  • cmd/operator-sdk: move 'olm-catalog gen-csv' subcommand to 'generate csv' and refactor command args into a struct

  • doc: change all relevant references to new command structure

Motivation for the change: since olm-catalog gen-csv is generating a CSV/package manifest, unifying this command with other generate commands makes sense.

@estroz estroz added refactoring olm-integration Issue relates to the OLM integration labels Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2020
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…csv',

and refactor command args into a struct

doc: change all relevant references to new command structure
@estroz estroz force-pushed the refactor/olm-catalog-cli branch from 7b4a4df to 9943fed Compare January 20, 2020 22:34
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@estroz estroz changed the title cmd/operator-sdk: move 'olm-catalog gen-csv' subcommand to 'generate csv' cmd/operator-sdk: 'olm-catalog gen-csv' -> 'generate csv' Jan 21, 2020
@estroz estroz merged commit 87ba308 into operator-framework:master Jan 21, 2020
@estroz estroz deleted the refactor/olm-catalog-cli branch January 21, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. olm-integration Issue relates to the OLM integration size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants