Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/operator-sdk: 'alpha bundle build' -> 'bundle create' #2438

Merged
merged 3 commits into from
Jan 21, 2020
Merged

cmd/operator-sdk: 'alpha bundle build' -> 'bundle create' #2438

merged 3 commits into from
Jan 21, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jan 20, 2020 •
edited
Loading

Description of the change: move alpha bundle build to bundle create.

Motivation for the change: no longer alpha.

@estroz estroz added refactoring olm-integration Issue relates to the OLM integration labels Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2020
@estroz estroz force-pushed the refactor/bundle-cli branch 3 times, most recently from 7794e39 to 5c455b6 Compare January 20, 2020 20:04
theishshah
theishshah approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending ci

joelanford
joelanford approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing comment.

Do we have any user guide style docs for the new bundle subcommand? If not, let's make a new issue to track adding something for that.

CHANGELOG.md Outdated Show resolved Hide resolved
@estroz estroz force-pushed the refactor/bundle-cli branch from 5c455b6 to 8c1da47 Compare January 20, 2020 22:08
@estroz
Copy link
Member Author

estroz commented Jan 20, 2020

@joelanford we do now: #2442. While we definitely need a doc, we should mostly be linking to operator-registry and the enhancement proposal wherever possible.

jmrodri
jmrodri approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2020
@estroz estroz changed the title cmd/operator-sdk: move 'bundle' subcommand out of 'alpha' cmd/operator-sdk: 'alpha bundle build' -> 'bundle create' Jan 21, 2020
@estroz estroz merged commit 3503cc0 into operator-framework:master Jan 21, 2020
@estroz estroz deleted the refactor/bundle-cli branch January 21, 2020 17:43
@joelanford joelanford mentioned this pull request Apr 2, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@joelanford joelanford joelanford approved these changes

@theishshah theishshah theishshah approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@jmrodri jmrodri

Labels
olm-integration Issue relates to the OLM integration size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estroz @openshift-ci-robot @jmrodri @joelanford @theishshah