internal/scaffold/olm-catalog/csv*.go: set install strategy if empty #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
added
kind/bug
estroz
requested review from
jmrodri,
joelanford,
jmccormick2001,
asmacdo,
hasbro17 and
camilamacedo86
openshift-ci-robot
added
the
size/S
CHANGELOG.md: add bugfix
estroz
force-pushed
the
bugfix/csv-unmarshal-strat
branch
from
1fecd43 to
72c9e6e
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: set install strategy if empty in CSV updaters.
Motivation for the change: if a CSV does not have an install strategy when being updated, a CSV updater will error when it should instead set the strategy to
StrategyDetailsDeployment(the only strategy available).