-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: allow relative paths for helm charts in watches.yaml file #2287
Helm: allow relative paths for helm charts in watches.yaml file #2287
Conversation
8c02d5f
to
1199c3e
Compare
1199c3e
to
e82d263
Compare
e82d263
to
9b5646e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking
I would like to test locally first.
9b5646e
to
9630fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm /approved
Description of the change:
Motivation for the change:
Allowing relative paths simplifies the experience of switching between
operator-sdk up local
and running in-cluster.Now local filesystem changes do not have to be made for
up local
to work. Previously, developers had to copy their chart to/opt/helm/helm-charts/<chart-name>
, create a symlink, or change their watches.yaml temporarily to point to the absolute path of their local project (and then be forced to change it back before runningoperator-sdk build
)