*: print-deps prints file of user's choice or by top-level file; remove --as-file #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
added
the
kind/feature
estroz
requested review from
jmrodri,
joelanford,
fabianvf,
hasbro17 and
theishshah
openshift-ci-robot
added
the
size/L
estroz
force-pushed
the
print-deps-remove-as-file
branch
from
bb7eb71 to
514cec3
Compare
hasbro17
reviewed
Aug 13, 2019
joelanford
reviewed
Aug 14, 2019
jmrodri
approved these changes
Aug 14, 2019
…top-level file; remove --as-file
estroz
force-pushed
the
print-deps-remove-as-file
branch
from
11721cd to
fd8a35e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
--as-file, which is now default behaviour--dep-managerso users can specify which type of file to print (default behavior is still old behavior)Motivation for the change: current
print-depswithout--as-fileerrors because our module files contain non-versions likemaster. These lines would need to be removed from the modfile's bytes and added back after parsing, a messy (and high LOC) process all for an output that is likely used less than that from--as-file.--dep-manageris a nice-to-have in case someone wants to switch dependency managers or loses their manager file somehow.Closes #1810