cmd/operator-sdk/new/cmd.go: fallback to default helm RBAC role without kubeconfig #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
lilic
suggested changes
Jul 2, 2019
| roleScaffold := helm.DefaultRoleScaffold | ||
| if k8sCfg, err := config.GetConfig(); err != nil { | ||
| log.Warnf("Using default RBAC rules: failed to get Kubernetes config: %s", err) | ||
| } else if dc, err := discovery.NewDiscoveryClientForConfig(k8sCfg); err != nil { |
There was a problem hiding this comment.
What happens here if k8sCfg is nil and we pass it to NewDiscoveryClientForConfig?
There was a problem hiding this comment.
In that case, config.GetConfig() would have to return nil, nil, which is probably not something that it would ever do. But better safe than sorry 🙂 . I'll check if the follow-on functions handle nil for both k8sCfg and dc.
There was a problem hiding this comment.
Missed the else part of the if, nvm. :)
|
/test marker |
|
/test e2e-aws-ansible |
|
/test e2e-aws-ansible |
1 similar comment
|
/test e2e-aws-ansible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Updates
operator-sdk new --type=helmto fallback to default RBAC rules if there is an error getting the kubeconfig or creating a discovery client.Motivation for the change:
Closes #1625