Upgrade the version of the dependency controller-runtime from v0.1.10 to v0.1.12

[andy2046]

Description of the change:

Changed

• Upgrade the version of the dependency controller-runtime from v0.1.10 to v0.1.12

Motivation for the change:
Address the issue in #1606

Closes #1606

[openshift-ci-robot]

Hi @andy2046. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andy2046]

@lilic CI is failing in test/e2e/ansible-molecule Scenario: 'test-local' Action: 'prepare', it's my first time running the CI, not sure what causes the error, need your guidance on this

[lilic]

/ok-to-test

[lilic]

Thanks for the PR, I restarted the failed job, it could be a timeout issue. Also started the other tests, will have a look a bit later.

[lilic]

Thanks for this!

We should also update the docs, do you mind doing that? https://github.com/operator-framework/operator-sdk/blob/9e91e5b1e774bcb84e0ba7ffd70d200f251d50f7/doc/user/unit-testing.md#using-a-fake-client

[lilic]

Suggested change

	- Upgrade the version of the dependency [controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from `v0.1.10` to `v0.1.12` [#1612](https://github.com/operator-framework/operator-sdk/pull/1612)
	- Upgrade the version of the dependency [controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from `v0.1.10` to `v0.1.12`. ([#1612](https://github.com/operator-framework/operator-sdk/pull/1612))

[joelanford]

@andy2046 There are a few more things that need to be covered as well:

• These changes cover the SDK itself, but they will not apply to scaffolded projects. Can you also update the gopkgtoml.go and go_mod.go files in internal/pkg/scaffold, internal/pkg/scaffold/ansible, and internal/pkg/scaffold/helm
• controller-runtime 0.1.12 also bumped the kubernetes version to 1.13.4, which we need to do as well, also in all of those files.

The go.mod templates have a // Pinned to kubernetes-1.13.1 section to update and the Gopkg.toml templates have overrides for version tags or revision SHAs that correspond to the kubernetes-1.13.* tag.

If you need help figuring out how to change those, let us know and we can help out.

[andy2046]

@joelanford thanks for the guidance, I have upgraded Kubernetes to v1.13.4, pls let me know if I missed out any other file.

[andy2046]

@lilic I have updated the docs, thanks.

[lilic]

@andy2046 seems like some e2e tests actually failed, doesn't look like a flake. Have you tried running the test locally to be able to debug this? Otherwise, we can help with figuring out the problem here, just let us know! Thanks for this!

[andy2046]

@lilic I can see the error came from test/subcommand/scorecard but when I ran make test/subcommand/scorecard locally, it passed without error, not sure what's happening there, need your hint to debug, thanks

[lilic]

@andy2046 green now. This was odd, anyways, ready for another round of reviews @joelanford

[joelanford]

/approve

[lilic]

Thanks for this!
/lgtm