Remove TypeMeta declaration from the implementation of the objects

[camilamacedo86]

Description of the change:

• Remove TypeMeta declaration from the implementation of the objects

Note that the TypeMeta struct and its values are automatically filled when an object is initialized in this way is unnecessary to add this values and indeed shows a not good practice at all since the dev can add wrong values which will cause issues as for example not allow the client GET the object.

Following an example which could cause error just to example this scenario.

    ...
    route := &routev1.Route{
        TypeMeta: v1.TypeMeta{  // TODO (user): Remove the TypeMeta declared
            APIVersion: "v1",   // the correct value should be `"route.openshift.io/v1"`
            Kind:       "Route",
        },
        ObjectMeta: v1.ObjectMeta{
            Name:      name,
            Namespace: namespace,
            Labels:    ls,
        },
    }
    ...

Following an example of the issue faced, it is because of the TypeMeta.APIVersion informed is invalid for the resource object schema. It is not recommended declared the TypeMeta since it will be implicitly generated.

get route: (no kind "Route" is registered for version "v1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:61")

Motivation for the change:

Face issues like the above example because of this unnecessary declaration.

[openshift-ci-robot]

Hi @camilamacedo86. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

c/c @lilic @shawn-hurley

[shawn-hurley]

/ok-to-test

[shawn-hurley]

I think it makes sense to clean this up, Thanks!

[hasbro17]

LGTM

[lilic]

Thanks for all your contributions @camilamacedo86! 🎉