Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Ansible test scaffold from k8s_facts to k8s_info module #2168

Closed
geerlingguy opened this issue Nov 6, 2019 · 2 comments · Fixed by #2203
Closed

Switch Ansible test scaffold from k8s_facts to k8s_info module #2168

geerlingguy opened this issue Nov 6, 2019 · 2 comments · Fixed by #2203
Labels
area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project

Comments

@geerlingguy
Copy link
Contributor

geerlingguy commented Nov 6, 2019 •
edited
Loading

Feature Request

Is your feature request related to a problem? Please describe.

When using the molecule test scaffold shipped with operator-sdk's Ansible option, playbook runs on Ansible 2.9 show a deprecation warning like the following:

    TASK [Wait 60s for reconciliation to run] ***************************************
[DEPRECATION WARNING]: The 'k8s_facts' module has been renamed to 'k8s_info'. 
This feature will be removed in version 2.13. Deprecation warnings can be 
disabled by setting deprecation_warnings=False in ansible.cfg.
    ok: [localhost]

Describe the solution you'd like

This is pretty easy to fix; we just need to change from using k8s_facts to k8s_info. I verified with a default test setup that this works identically and drops the deprecation warnings.
@geerlingguy geerlingguy mentioned this issue Nov 6, 2019
Closed
5 tasks
@camilamacedo86 camilamacedo86 added language/ansible Issue is related to an Ansible operator project area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. labels Nov 6, 2019
@camilamacedo86
Copy link
Contributor

HI @geerlingguy,

Thank you for raise it. Also, please feel free to collab with the PR if you wish.

@camilamacedo86 camilamacedo86 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 7, 2019
@geerlingguy geerlingguy mentioned this issue Nov 15, 2019
Merged
@geerlingguy
Copy link
Contributor Author

Added PR (see above).

camilamacedo86 pushed a commit that referenced this issue Nov 26, 2019
@geerlingguy @camilamacedo86
Use k8s_info module instead of deprecated k8s_facts in molecule scaff…
cf1ca34 
…old (#2168) (#2203)

* Use k8s_info module instead of deprecated k8s_facts in molecule scaffold (#2168)
* Update Ansible minimum version to 2.9 in various Dockerfiles (#2203)
* CHANGELOG updates for Ansible test scaffold changes (#2203)
@jmazzitelli jmazzitelli mentioned this issue Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use k8s_info module instead of deprecated k8s_facts in molecule scaffold (#2168)
2 participants
@geerlingguy @camilamacedo86