move internal to alpha to make subpackages available for importing from other projects #759

joelanford · 2021-08-19T15:49:25Z

Signed-off-by: Joe Lanford [email protected]

Description of the change:
Wholesale move of internal to alpha

Using alpha name to denote that these packages do not yet have stable Go APIs, and added a doc.go to explain what being in the alpha tree means:

// Package alpha contains subpackages that have unstable Go APIs.
// Subpackages that achieve maturity will be deprecated and moved
// to other modules or packages within operator-registry.
//
// Presence in the alpha package should not be construed as being
// of less quality than non-alpha packages. Subpackages in the
// alpha package have the same standard for testing as all other
// packages in this repository.
package alpha

Motivation for the change:
To make file-based config packages available to be imported by other projects.

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

codecov · 2021-08-19T15:55:50Z

Codecov Report

Merging #759 (6491804) into master (7fba6ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   50.29%   50.29%           
=======================================
  Files         101      101           
  Lines        8699     8699           
=======================================
  Hits         4375     4375           
  Misses       3471     3471           
  Partials      853      853

Impacted Files	Coverage Δ
alpha/action/diff.go	`64.70% <ø> (ø)`
alpha/action/generate_dockerfile.go	`81.81% <ø> (ø)`
alpha/action/init.go	`100.00% <ø> (ø)`
alpha/action/list.go	`67.70% <ø> (ø)`
alpha/action/render.go	`60.94% <ø> (ø)`
alpha/declcfg/declcfg.go	`100.00% <ø> (ø)`
alpha/declcfg/declcfg_to_model.go	`76.19% <ø> (ø)`
alpha/declcfg/diff.go	`77.45% <ø> (ø)`
alpha/declcfg/load.go	`83.56% <ø> (ø)`
alpha/declcfg/model_to_declcfg.go	`100.00% <ø> (ø)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fba6ad...6491804. Read the comment docs.

estroz

/lgtm

openshift-ci · 2021-08-19T16:27:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-19T16:41:31Z

/retest-required