-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller/registry: implement content extraction for catalog sources #3029
controller/registry: implement content extraction for catalog sources #3029
Conversation
1c46464
to
0b67234
Compare
24a7bb6
to
be2e37c
Compare
be2e37c
to
3be8160
Compare
Signed-off-by: Steve Kuznetsov <[email protected]>
1745498
to
956d12b
Compare
@joelanford made the changes you suggested. I've used this approach often in the past and found it useful, but only with statically-compiled binaries under my own control. If anything in |
Signed-off-by: Steve Kuznetsov <[email protected]>
956d12b
to
115eccf
Compare
@@ -38,7 +38,7 @@ var ( | |||
|
|||
communityOperators = flag.String( | |||
"communityOperators", | |||
"quay.io/operator-framework/upstream-community-operators@sha256:098457dc5e0b6ca9599bd0e7a67809f8eca397907ca4d93597380511db478fec", | |||
"quay.io/operatorhubio/catalog:latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelanford unfortunately the specific SHAs for this image are not kept around for very long, as there are no long-lived tags. We will have to suffice with :latest
, which might break tests if they are asserting on specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine for now. It'd be nice if we did the thing we are now doing in catalogd and operator-controller where we have all of our test artifacts actually come out of the repo.
Definitely not a blocker for this though, IMO.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
go.mod: update the api dependency
Signed-off-by: Steve Kuznetsov [email protected]
controller/registry: implement content extraction for catalog sources
Signed-off-by: Steve Kuznetsov [email protected]
Implements #3019