feat: informer related behavior on startup and in case of errors #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 26, 2022
csviri
changed the title
csviri
changed the title
|
Note that tried to make a distinction of integration tests based on Tag but there were issues with it in surefire plugin |
metacosm
requested changes
Oct 26, 2022
...ramework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java
Show resolved
Hide resolved
.../main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java
Show resolved
Hide resolved
...va/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSourceTest.java
Show resolved
Hide resolved
|
LGTM apart from the comments |
csviri
force-pushed
the
startup-informers-rbac
branch
from
cc340ba to
66bc039
Compare
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Oct 27, 2022
csviri
added a commit
that referenced
this pull request
Oct 28, 2022
csviri
added a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement behavior requested in #1422
The sync timeout is also implemented. But might move it to the controller level (as in controller runtime) in a separate PR.