Makefile changes for addition of run bundle in Java Plugin. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laxmikantbpandhare
requested review from
jmrodri,
metacosm,
theishshah and
everettraven
laxmikantbpandhare
changed the title
jmrodri
requested changes
May 21, 2022
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
laxmikantbpandhare
added
the
do-not-merge/work-in-progress
|
@jmrodri - Worked on all the review comments. Could you please review once. |
laxmikantbpandhare
removed
do-not-merge/hold
laxmikantbpandhare
added
api-review
…ti-createapi modified code for handling multiple create api commands
…ti-createapi update space
|
I ran it twice and the update looks great. $ diff -u Makefile /tmp/Makefile
--- Makefile 2022-06-01 23:21:22.691820093 -0400
+++ /tmp/Makefile 2022-06-01 23:21:14.750800304 -0400
@@ -49,7 +49,7 @@
.PHONY: bundle
bundle: ## Generate bundle manifests and metadata, then validate generated files.
## marker
- cat target/kubernetes/memcacheds.cache.example.com-v1.yml target/kubernetes/jokes.cache.example.com-v1.yml target/kubernetes/kubernetes.yml | operator-sdk generate bundle -q --overwrite --version 0.1.1 --default-channel=stable --channels=stable --package=memcached-quarkus-operator
+ cat target/kubernetes/memcacheds.cache.example.com-v1.yml target/kubernetes/kubernetes.yml | operator-sdk generate bundle -q --overwrite --version 0.1.1 --default-channel=stable --channels=stable --package=memcached-quarkus-operator
operator-sdk bundle validate ./bundle
.PHONY: bundle-build |
jmrodri
reviewed
Jun 2, 2022
jmrodri
reviewed
Jun 2, 2022
jmrodri
reviewed
Jun 2, 2022
| makefileBundleVarFragment = ` | ||
| ##@Bundle | ||
| .PHONY: bundle | ||
| bundle: ## Generate bundle manifests and metadata, then validate generated files. |
There was a problem hiding this comment.
I won't hold this PR up but I think we need to make this depend on a build target.
.PHONY: build
build:
mvn install
.PHONY: bundle
bundle: build
cat target...Basically in our other projects if we run make bundle it will do a generation and create the manifests required. But in Java, it won't. But that's because we're not calling anything from make bundle.
There was a problem hiding this comment.
Yes agree, we must add mvn install before generating the bundle else it will fail if the User is not compiled the project before generating the bundle manifest. Let me try to add this to the existing logic.
There was a problem hiding this comment.
Quick question here, when the User tries the below command at that moment itself it will generate the /target directory.
make docker-build docker-push IMG=quay.io/YOURUSER/memcached-quarkus-operator:0.0.1
Do you still think we still need to add mvn clean install in the bundle structure?
…ti-createapi modified minor changes
That's great. Thank you for confirming this. |
everettraven
approved these changes
Jun 2, 2022
…ti-createapi added logs for plugin Makefile
everettraven
reviewed
Jun 2, 2022
…ti-createapi remove comments from plugin Makefile
…ti-createapi remove comments from plugin Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will add changes to Makefile for
run bundle. As we need version and group name, I moved Makefile from templates to API.Able to scaffold out Makefile with required changes and able to generate the bundle files and able to run it too.
Please find below the output after running the bundle command:
operator-sdk run bundle docker.io/013859989/memcached-quarkus-operator-bundle:v0.0.98