Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

New channel due to missing replaces #1992

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

J0zi
Copy link
Collaborator

@J0zi J0zi commented Jul 15, 2020

Hi @pb82,

we added a version to separate channel as it actually fall off the update graph and are orphaned and not installable / upgradable anymore due to missing replaces in the path. After this PR, it will be installable from this channel.
The main reason for this update is that we are currently preparing to enable bundle based catalogs which involves background conversion, it’s currently failing for the reason stated above. Please approve with /lgtm.

Signed-off-by: j0zi [email protected]

Thanks submitting your Operator. Please check below list before you create your Pull Request.


Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.


New Submissions

Updates to existing Operators

  • Is your new CSV pointing to the previous version with the replaces property?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@openshift-ci-robot openshift-ci-robot added the kubernetes-operator An Operator targeting OperatorHub.io label Jul 15, 2020
@pb82
Copy link
Contributor

pb82 commented Jul 15, 2020

@J0zi the missing replace was intentional as there is no automatic upgrade path from 2.x.x to 3.x.x. Is there a better way to handle such scenarios?

@pb82
Copy link
Contributor

pb82 commented Jul 15, 2020

/lgtm

@openshift-ci-robot
Copy link
Collaborator

@pb82: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmesser
Copy link
Collaborator

dmesser commented Jul 16, 2020

@pb82 When there is no replaces or skips instructions these things fall out of the update graph completely. This is because that graph is constructed by looking at what's latest in a channel and then walk back via these pointers. If nothing points anymore to your 2.x.x version the graph ends at the earliest 3.x.x release. While this could be intentional it is also disruptive for users. We have ways around that by serving 2.x.x in a separate channel.

j0zi added 3 commits July 20, 2020 16:49
Signed-off-by: j0zi <[email protected]>
Signed-off-by: j0zi <[email protected]>
@J0zi J0zi force-pushed the RHO-644-grafana-operator branch from fb54e54 to 2f935e9 Compare July 20, 2020 14:50
@J0zi J0zi closed this Jul 21, 2020
@J0zi J0zi reopened this Jul 21, 2020
@J0zi J0zi merged commit 52f0260 into operator-framework:master Jul 21, 2020
J0zi added a commit to J0zi/community-operators that referenced this pull request Jul 23, 2020
* New channel due to missing replaces

Signed-off-by: j0zi <[email protected]>

* temp

Signed-off-by: j0zi <[email protected]>

* def channel

Signed-off-by: j0zi <[email protected]>

Co-authored-by: j0zi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kubernetes-operator An Operator targeting OperatorHub.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants