updating dependencies and code to support k8s 1.28

[acornett21]

Description of the change:

• Relates: Meta Issue for k8s 1.28 bump operator-sdk#6554
• Updating go dependecies to support k8s 1.28
• Updating code to support k8s dependency changes
• Updating pip dependencies and container dependencies so that container can be built

Motivation for the change:
To keep project current.

e2e tests failing

[everettraven]

Looks like the e2e tests are failing due to

ansible-operator-plugins/internal/ansible/flags/flag.go

Line 165 in ba5d25a

"configmapsleases",

- need to update this to "leases" I think.

[acornett21]

Looks like the e2e tests are failing due to

ansible-operator-plugins/internal/ansible/flags/flag.go

Line 165 in ba5d25a

"configmapsleases",

• need to update this to "leases" I think.

I'm not sure what we want to do for this flag, since there can only be one value now and it's hardcoded to resourcelock.LeasesResourceLock (I have yet to push that update). The helm plugin does not expose this flag, so I'm not sure if removal or deprecation is the best option for this flag.

[everettraven]

Looks like the e2e tests are failing due to

ansible-operator-plugins/internal/ansible/flags/flag.go

Line 165 in ba5d25a

"configmapsleases",

• need to update this to "leases" I think.

I'm not sure what we want to do for this flag, since there can only be one value now and it's hardcoded to resourcelock.LeasesResourceLock (I have yet to push that update). The helm plugin does not expose this flag, so I'm not sure if removal or deprecation is the best option for this flag.

Based on https://github.com/kubernetes-sigs/controller-runtime/blob/6747c42ce33966b0e77cac278c6b9087cc2f51c7/pkg/manager/manager.go#L146-L177 it looks like we should update the default value of that flag to "leases"

[acornett21]

Based on https://github.com/kubernetes-sigs/controller-runtime/blob/6747c42ce33966b0e77cac278c6b9087cc2f51c7/pkg/manager/manager.go#L146-L177 it looks like we should update the default value of that flag to "leases"

Just to restate again, there can only be one value and it's hardcoded and cannot come from the flag, so IMO the flag doesn't serve a purpose and should either be deprecated or removed. I'd prefer removal since other plugins do not have this flag.

[everettraven]

Based on https://github.com/kubernetes-sigs/controller-runtime/blob/6747c42ce33966b0e77cac278c6b9087cc2f51c7/pkg/manager/manager.go#L146-L177 it looks like we should update the default value of that flag to "leases"

Just to restate again, there can only be one value and it's hardcoded and cannot come from the flag, so IMO the flag doesn't serve a purpose and should either be deprecated or removed. I'd prefer removal since other plugins do not have this flag.

Maybe I'm misunderstanding, but I don't see a reason for this to be hardcoded? This still appears to be a configurable option based on https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/manager#Options. The default should be updated to reflect the default used by controller-runtime and the description updated to reflect what controller-runtime recommends, which is that this option only be modified if you know what you are doing.

We most certainly can deprecate this flag, but we unfortunately cannot just remove it.

EDIT: To add onto this, I do see that in client-go the only possible resource lock is "leases" https://github.com/kubernetes/client-go/blob/94205f8c40c617ffa7b5cf1927448cfd2e99ebf5/tools/leaderelection/resourcelock/interface.go#L166-L189

That being said, I think it makes sense to keep this a configurable flag since it is configurable in controller-runtime. Doesn't mean anything but "leases" has to work (and we can document this if necessary) but keeping it around prevents additional work beyond modifying the default if in the future there are new resource lock types added/removed/changed

[everettraven]

I don't think we can just remove this without it being a breaking change and requiring a new major version. I'd prefer if we changed this to something like:

	flagSet.StringVar(&f.LeaderElectionResourceLock,
		"leader-elect-resource-lock",
		resourcelock.LeasesResourceLock,
		"determines which resource lock to use for leader election, defaults to \"leases\". Change this value only if you know what you are doing.",
	)

and then remove the hardcoded setting below

[everettraven]

I think it's also acceptable to deprecate this flag and have it "do nothing". We just can't remove it right now

[acornett21]

This flag isn't in the helm-plugin so I was trying to remove it for consistency/clarity across plugins. I'll move to deprecate it, since IMO that's more clear to end users.

[everettraven]

Marking as "Request Changes" to properly signal the review status of this PR from my end. Reasoning for requesting changes is https://github.com/operator-framework/ansible-operator-plugins/pull/51/files#r1457477413

[everettraven]

/lgtm

Will merge pending passing CI

[openshift-ci]

New changes are detected. LGTM label has been removed.