Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fields for structured docs #76

Merged
merged 2 commits into from
Sep 8, 2016

Conversation

vanstee
Copy link
Member

@vanstee vanstee commented Sep 6, 2016

Depends on #75

Previously, bundles could include both Slack and HipChat templates. With
the new templating engine, we now only need one template (the specific
chat provider implementations will be responsible for rendering the
template in a manner appropriate to the chat platform).

Now, templates look like this:

```
...
"templates": {
  "template1": {"body": "template1 body"},
  "template2": {"body": "template2 body"},
  ...
}
...

```

Note now that template names are also constrained to the regex
`[A-Za-z0-9_]+`.

This sets the current bundle definition version to 4, and officially
removes support for version 2 bundles. Version 3 is now officially
deprecated.
@vanstee vanstee added the review label Sep 6, 2016
@vanstee vanstee force-pushed the vanstee/structured-docs branch from dc9b975 to 5899351 Compare September 6, 2016 18:27
@christophermaier christophermaier merged commit 5d36487 into master Sep 8, 2016
@christophermaier christophermaier deleted the vanstee/structured-docs branch September 8, 2016 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants