Create log file if it doesn't exist #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophermaier
force-pushed
the
cm/open-log-file
branch
from
604dd6e to
98a910d
Compare
kevsmith
approved these changes
Nov 4, 2016
| @@ -70,7 +70,7 @@ func configureLogger(config *config.Config) { | |||
| case "stdout": | |||
| log.SetOutput(os.Stdout) | |||
| default: | |||
| logFile, err := os.Open(config.LogPath) | |||
| logFile, err := os.OpenFile(config.LogPath, os.O_WRONLY | os.O_APPEND | os.O_CREATE, 0644) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes operable/cog#1123
Initially I thought of handling log rotation with this change as well, but decided against it for the time being. The current change fixes the original functionality that was intended to be present, and no more. To properly support log rotation, we'd need to either monitor inodes, reopen the file for each write (something that https://github.com/rifflock/lfshook actually does, and I initially thought to use, though that requires a little more work to mirror the functionality we currently have), or (my current inclination) implement a signal handler for
SIGHUPwhich would reopen log files (and probably config files, too), in keeping with many other UNIX programs, and easily utilized with programs likelogrotate. (Right now, aSIGHUPwill terminate the Relay process, which is default behavior for Go programs.)