Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permission command to use args, not options #793

Merged
merged 1 commit into from
Jun 23, 2016

Conversation

christophermaier
Copy link
Collaborator

Boldly, into the future!

Fixes #675

msg_map
|> Enum.map(fn({field, msg}) -> "#{field} #{msg}" end)
|> Enum.join("\n")
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really wish Phoenix came with a function that does this. Had to write something similar for Flywheel.

@vanstee
Copy link
Member

vanstee commented Jun 23, 2016

LGTM. Do we have an issue to double check that all permission command references are updated in the docs?

@christophermaier
Copy link
Collaborator Author

christophermaier commented Jun 23, 2016

@vanstee That's a good call... I'll make one.

EDIT: #797

@christophermaier christophermaier merged commit a8fa0a6 into master Jun 23, 2016
@christophermaier christophermaier deleted the cm/rework-permissions branch June 23, 2016 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants