Query rule for mentioned permissions #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2016 15:39
This commit uses the newly added Permissions.Ast.Rule.permissions_used/1 function to obtain the list of permissions mentioned in a access rule to generate a better access denied error message. This also prevents Cog from crashing when rules mention more than one permission. This isn't an ideal solution as we're not telling the user exactly which specific permissions they're lacking but it is a step in the right direction and vastly better than crashing. 50% fix for #758
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the newly proposed
Permissions.Ast.Rule.permissions_used/1function to obtain the list of permissions mentioned in a access rule to generate a better access denied error message. This also prevents Cog from crashing when rules mention more than one permission.This isn't an ideal solution as we're not telling the user exactly which specific permissions they're lacking but it is a step in the right direction and vastly better than crashing.
50% fix for #758