Improve list templates and fix failing tests due to bugfixes #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanstee
force-pushed
the
vanstee/list-command-improvements
branch
from
d380e3b to
c339d8a
Compare
vanstee
force-pushed
the
vanstee/list-command-improvements
branch
from
c00e53f to
78b697f
Compare
vanstee
commented
Jan 3, 2017
vanstee
force-pushed
the
vanstee/list-command-improvements
branch
from
54297d8 to
2bf520a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes here revolve around making list commands print scannable output. The only exception is
rule listas other commands require an id, but we need to show the entire rule since that's really the only identifiable information available.Tests were also fixed to remove newlines and join tags and extra break tags in hipchat output which were each related to recent greenbar bugfixes.