Alias test rework #1124
Merged
Alias test rework #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeck
force-pushed
the
peck/alias-tests
branch
from
d5ade83 to
927e87c
Compare
vanstee
reviewed
Nov 7, 2016
| @@ -14,7 +14,7 @@ defmodule Cog.Commands.Alias.Create do | |||
| -h, --help Display this usage info | |||
|
|
|||
| EXAMPLE | |||
| alias create my-awesome-alias "echo \"My awesome alias\"" | |||
| alias create my-awesome-alias \"echo \"My awesome alias\"\" | |||
There was a problem hiding this comment.
I don't think escaping those quotes are necessary here, although I think Elixir renders them just the same inside a triple quote block.
There was a problem hiding this comment.
I actually added that because my syntax highlighter was getting mucked up and it was difficult to tell what was going on. I meant to remove it. My bad.
mpeck
force-pushed
the
peck/alias-tests
branch
from
aa53501 to
3b696d0
Compare
kevsmith
approved these changes
Nov 11, 2016
mpeck
force-pushed
the
peck/alias-tests
branch
from
3b696d0 to
96ed097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
aliascommand tests. This also includes work to thewhichcommand tests since they are tied closely to aliases.part of #1122