Cleanup adaptor #477
Merged
Cleanup adaptor #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-dcouto
requested review from
andrewpmartinez,
plorenz,
dovholuknf and
JeremyTellier
dovholuknf
reviewed
Nov 10, 2021
service/ziti-tunnel/service/ipc.go
Outdated
| @@ -90,6 +90,7 @@ func SubMain(ops chan string, changes chan<- svc.Status, winEvents <-chan Window | |||
| // initialize the network interface | |||
| err := initialize(cLogLevel) | |||
| if err != nil { | |||
| rts.Close() | |||
There was a problem hiding this comment.
maybe it would make more sense to just defer rts.Close() ?
There was a problem hiding this comment.
probably just before initialize is called. when this function exits - the service is shutting down. seems like it makes sense to defer it
dovholuknf
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #476
This fix cleans up the tun adaptor if WDE fails during the initialisation of tun. I could not reproduce the issue where the tun will be in hung state. So I could not test the clean up of adaptor that is in hung state.